dianfu commented on a change in pull request #9874: [FLINK-14240][table] Merge
table config parameters(TableConfig#getConfiguration) into global job
parameters(ExecutionConfig#getGlobalJobParameters) when running with the legacy
planner.
URL: https://github.com/apache/flink/pull/9874#discussion_r333343082
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/batch/table/TableEnvironmentITCase.scala
##########
@@ -203,6 +203,22 @@ class TableEnvironmentITCase(
val expected = List("1,1,Hi", "2,2,Hello", "3,2,Hello world")
assertEquals(expected.sorted,
MemoryTableSourceSinkUtil.tableDataStrings.sorted)
}
+
+ @Test
+ def testMergeParameters(): Unit = {
+ val env = ExecutionEnvironment.getExecutionEnvironment
+ val tEnv = BatchTableEnvironment.create(env)
+
+ val t = CollectionDataSets.getSmall3TupleDataSet(env).toTable(tEnv).as('a,
'b, 'c)
+
+ tEnv.getConfig.getConfiguration.setString("testConf", "1")
+
Review comment:
remove this kind of empty lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
