docete commented on a change in pull request #9796: 
[FLINK-14253][table-planner-blink] Add hash distribution and sort grouping only 
when dynamic partition insert
URL: https://github.com/apache/flink/pull/9796#discussion_r333365017
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchExecSinkRule.scala
 ##########
 @@ -47,8 +47,10 @@ class BatchExecSinkRule extends ConverterRule(
     sinkNode.sink match {
       case partitionSink: PartitionableTableSink
         if partitionSink.getPartitionFieldNames != null &&
-          partitionSink.getPartitionFieldNames.nonEmpty =>
+          partitionSink.getPartitionFieldNames.nonEmpty &&
+          partitionSink.getPartitionFieldNames.size() > 
sinkNode.staticPartitions.size =>
         val partitionFields = partitionSink.getPartitionFieldNames
 
 Review comment:
   Use dynamicPartitionFields ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to