hequn8128 commented on a change in pull request #9851: [FLINK-14341]Fix
flink-python builds failure: no such option: --prefix
URL: https://github.com/apache/flink/pull/9851#discussion_r333410587
##########
File path: flink-python/pyflink/gen_protos.py
##########
@@ -120,10 +120,20 @@ def
_install_grpcio_tools_and_generate_proto_files(force, output_dir):
logging.warning('Installing grpcio-tools into %s', install_path)
try:
start = time.time()
- subprocess.check_call(
- [sys.executable, '-m', 'pip', 'install',
- '--prefix', install_path, '--build', build_path,
- '--upgrade', GRPC_TOOLS, "-I"])
+ # since '--prefix' option only supported for pip 8.0+, so here we
fallback to
+ # use `--install-option` when the pip version is lower than 8.0.0.
Review comment:
maybe keep consistent with --prefix is better, i.e., `'--install-option'`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
