zhijiangW commented on issue #9646:  [FLINK-14004][runtime] Define 
SourceReaderOperator to verify the integration with StreamOneInputProcessor
URL: https://github.com/apache/flink/pull/9646#issuecomment-540505424
 
 
   Thanks for the further confirmation and pushing forward this work.
   
   I agree with the conclusion that we could only touch `SourceReaderOperator` 
in this PR and not care about the interactive details between 
`SourceReaderOperator` and `SourceReader`.
   
   In detail I think it is better to only give an abstract 
`SourceReaderOperator` to provide `emitNext` and `isAvailable` methods for 
runtime call, and implement this operator only in unit tests to verify the 
whole process ATM. Then after FLIP-27 ready, it could implement the former 
`SourceReaderOperator` with `SourceReader` together.
   
   I already updated the codes based on the above confirmation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to