1u0 commented on a change in pull request #9870: [FLINK-14350][metrics]
Introduce dedicated MetricScope
URL: https://github.com/apache/flink/pull/9870#discussion_r333474919
##########
File path:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java
##########
@@ -174,10 +174,10 @@ public void report() {
/**
* Get tags from MetricGroup#getAllVariables(), excluding 'host'.
*/
- private List<String> getTagsFromMetricGroup(MetricGroup metricGroup) {
+ private List<String> getTagsFromMetricGroup(MetricScope scope) {
Review comment:
Nit: The method name is outdated with this change.
Suggestion: rename this method to `getTagsFromMetricScope()` or just
`getTags()`?
Same for the method bellow (`getHostFromMetricGroup()`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
