GJL commented on a change in pull request #9860: [FLINK-14331][runtime] Reset
vertices right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#discussion_r333506554
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -225,13 +230,21 @@ protected void scheduleOrUpdateConsumersInternal(final
ExecutionVertexID produce
@Override
public void allocateSlotsAndDeploy(final
Collection<ExecutionVertexDeploymentOption> executionVertexDeploymentOptions) {
- final Map<ExecutionVertexID, ExecutionVertexDeploymentOption>
deploymentOptionsByVertex =
groupDeploymentOptionsByVertexId(executionVertexDeploymentOptions);
+ final Collection<ExecutionVertexDeploymentOption>
validDeploymentOptions = executionVertexDeploymentOptions.stream()
Review comment:
Is it legal to schedule vertices in states other than `CREATED`? I wonder if
this should be a `checkState`.
Nonetheless, I would extract this code into a separate method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
