zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime]
Reset vertices right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#discussion_r333551985
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -211,7 +215,8 @@ private Runnable restartTasks(final
Set<ExecutionVertexVersion> executionVertexV
}
private CompletableFuture<?> cancelExecutionVertex(final
ExecutionVertexID executionVertexId) {
- return
executionVertexOperations.cancel(getExecutionVertex(executionVertexId));
+ return
executionVertexOperations.cancel(getExecutionVertex(executionVertexId))
+ .whenComplete((Object ignored, Throwable t) ->
executionSlotAllocator.cancel(executionVertexId));
Review comment:
It's similar to the slot request cancellation registered in
`Execution#allocateAndAssignSlotForExecution`.
In my understanding, doing it after the cancellation finishes means the
vertex(Execution) has reached a stable terminated state then. So that the later
calls triggered by executionSlotAllocator.cancel() can return early without any
complex logic that may change the vertex state. This can make things easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
