azagrebin commented on a change in pull request #9821: [FLINK-14298] Replace
LeaderContender#getAddress with #getDescription
URL: https://github.com/apache/flink/pull/9821#discussion_r333570301
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedHaServicesTest.java
##########
@@ -120,52 +119,41 @@ public void testResourceManagerLeaderElection() throws
Exception {
*/
@Test
public void testJobManagerLeaderRetrieval() throws Exception {
- final String address = "foobar";
JobID jobId = new JobID();
- LeaderRetrievalListener leaderRetrievalListener =
mock(LeaderRetrievalListener.class);
- LeaderContender leaderContender = mock(LeaderContender.class);
- when(leaderContender.getAddress()).thenReturn(address);
LeaderElectionService leaderElectionService =
embeddedHaServices.getJobManagerLeaderElectionService(jobId);
LeaderRetrievalService leaderRetrievalService =
embeddedHaServices.getJobManagerLeaderRetriever(jobId);
+ runLeaderRetrievalTest(leaderElectionService,
leaderRetrievalService);
+ }
+
+ private void runLeaderRetrievalTest(LeaderElectionService
leaderElectionService, LeaderRetrievalService leaderRetrievalService) throws
Exception {
+ LeaderRetrievalUtils.LeaderConnectionInfoListener
leaderRetrievalListener = new
LeaderRetrievalUtils.LeaderConnectionInfoListener();
+ TestingLeaderContender leaderContender = new
TestingLeaderContender();
+
leaderRetrievalService.start(leaderRetrievalListener);
leaderElectionService.start(leaderContender);
- ArgumentCaptor<UUID> leaderIdArgumentCaptor =
ArgumentCaptor.forClass(UUID.class);
-
verify(leaderContender).grantLeadership(leaderIdArgumentCaptor.capture());
-
- final UUID leaderId = leaderIdArgumentCaptor.getValue();
+ final UUID leaderId =
leaderContender.getLeaderSessionFuture().get();
+ final String address = "foobar";
Review comment:
this address could be a constant of `TestingLeaderContender`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
