zentol commented on a change in pull request #9867: [FLINK-7958][metrics]
Reporters provide default delimiter
URL: https://github.com/apache/flink/pull/9867#discussion_r333832960
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -147,7 +147,7 @@ public MetricRegistryImpl(MetricRegistryConfiguration
config, Collection<Reporte
}
reporters.add(reporterInstance);
- String delimiterForReporter =
reporterSetup.getDelimiter().orElse(String.valueOf(globalDelimiter));
Review comment:
the abstract metric group can be used a) by reporters, in which case we rely
on the reporter defined here, and b) user-functions, in which case they still
rely on the global delimiter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
