zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime]
Reset vertices right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#discussion_r333956291
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -235,6 +236,9 @@ public void allocateSlotsAndDeploy(final
Collection<ExecutionVertexDeploymentOpt
final Map<ExecutionVertexID, ExecutionVertexDeploymentOption>
deploymentOptionsByVertex =
groupDeploymentOptionsByVertexId(executionVertexDeploymentOptions);
+ checkArgument(executionVertexDeploymentOptions.size() ==
deploymentOptionsByVertex.size(),
Review comment:
You are right. We can drop this change.
Here's the java doc of `Collectors.toMap()`
> <p>If the mapped keys contains duplicates (according to
> * {@link Object#equals(Object)}), an {@code IllegalStateException} is
> * thrown when the collection operation is performed. If the mapped
keys
> * may have duplicates, use {@link #toMap(Function, Function,
BinaryOperator)}
> * instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
