azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r334025529
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/KeyedBudget.java ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.memory; + +import org.apache.flink.types.Either; + +import javax.annotation.concurrent.GuardedBy; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Map.Entry; + +class KeyedBudget<K> { Review comment: ok, I will add a javadoc with a general class description. For class name, not sure about the better name, I could name it `KeyedBudgetManager`. Regarding the `MemorySize` usage, `KeyedBudget` is designed as a general purpose component, it is not necessary about memory. Maybe, it is even better idea if I move it to the `util` package. True, `MemorySize` is a nicer API. `MemorySize` is also a mostly user facing class from what I see. My thinking is that `MemoryManger` is a Flink internal component and all its users does not seem to be interested in memory units atm but rather all work with bytes. Although wrapping will not add too much overhead, I would keep it as it is now. We can always do a separate follow-up hotfix where we add/switch to `MemorySize` API if there will be use cases for memory units in `MemoryManger`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
