carp84 commented on a change in pull request #9501: [FLINK-12697] [State
Backends] Support on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#discussion_r334177724
##########
File path:
flink-state-backends/flink-statebackend-heap-spillable/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteSkipListStateMap.java
##########
@@ -1367,6 +1317,14 @@ public Long next() {
}
}
+ private Tuple2<ByteBuffer, Integer> getNodeByteBufferAndOffset(long
node) {
Review comment:
ok, the change was following [previous review
comment](https://github.com/apache/flink/pull/9501#discussion_r320370445) and
let me further improve it. However, I'd like to point out again that such
operations are on the core path and will be invoked frequently, which makes the
creation of temporary objects a real burden for GC. Now I cannot tell the
detailed performance impact or number since it's still half way (or less)
upstreamed, but I will keep an eye on the cost of such refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
