wangxlong commented on a change in pull request #9823: [FLINK-14273][Table]Add
accumulator type to actual type list in AggSqlFunction
URL: https://github.com/apache/flink/pull/9823#discussion_r334217609
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/functions/utils/AggSqlFunction.scala
##########
@@ -107,7 +107,8 @@ object AggSqlFunction {
private[flink] def createOperandTypeInference(
name: String,
aggregateFunction: UserDefinedAggregateFunction[_, _],
- typeFactory: FlinkTypeFactory): SqlOperandTypeInference = {
+ typeFactory: FlinkTypeFactory,
+ externalAccType: DataType): SqlOperandTypeInference = {
Review comment:
Thank you for your advice. So, can we just write as follow?
`val actualSignature = externalAccType.getLogicalType +: operandTypeInfo`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
