zhuzhurk commented on a change in pull request #9860: [FLINK-14331][runtime]
Reset vertices right after they transition to terminated states
URL: https://github.com/apache/flink/pull/9860#discussion_r334388725
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -706,8 +706,10 @@ private Execution resetForNewExecutionInternal(final long
timestamp, final long
public void tryAssignResource(LogicalSlot slot) {
if (!currentExecution.tryAssignResource(slot)) {
- throw new IllegalStateException("Could not assign
resource " + slot + " to current execution " +
- currentExecution + '.');
+ final IllegalStateException e = new
IllegalStateException(
+ "Could not assign resource " + slot + " to
current execution " + currentExecution + '.');
+ slot.releaseSlot(e);
Review comment:
Ok. Agreed that `tryAssignResource` should never fail in
`DefaultScheduler#assignResourceOrHandleError` unless there is a bug.
Let's drop this hotfix.
I think we do not need to change `assertNoException`. Changing
`.handle(deployOrHandleError...` to `.thenAccept(deployOrHandleError...` should
work for this purpose.
And I'd prefer to do this after we have unified the deployment logic in
FLINK-14162.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
