godfreyhe commented on a change in pull request #8468:
[FLINK-12399][table][table-planner] Fix FilterableTableSource does not change
after applyPredicate
URL: https://github.com/apache/flink/pull/8468#discussion_r334479740
##########
File path:
flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java
##########
@@ -213,7 +213,8 @@ public boolean isFilterPushedDown() {
@Override
public String explainSource() {
- return "OrcFile[path=" + path + ", schema=" + orcSchema + ",
filter=" + predicateString() + "]";
+ return "OrcFile[path=" + path + ", schema=" + orcSchema + ",
filter=" + predicateString()
Review comment:
in `predicateString` method, it's better return `TRUE` if predicates is null
or empty, otherwise return predicates string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
