tillrohrmann commented on a change in pull request #9501: [FLINK-12697] [State
Backends] Support on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#discussion_r334581633
##########
File path:
flink-state-backends/flink-statebackend-heap-spillable/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteSkipListStateMap.java
##########
@@ -1367,6 +1317,14 @@ public Long next() {
}
}
+ private Tuple2<ByteBuffer, Integer> getNodeByteBufferAndOffset(long
node) {
Review comment:
Fair enough. I think it is important to keep an eye on the performance.
Whether a `Tuple2` or a bit more expressive class is instantiated should not
matter much, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
