walterddr commented on a change in pull request #8468: 
[FLINK-12399][table][table-planner] Fix FilterableTableSource does not change 
after applyPredicate
URL: https://github.com/apache/flink/pull/8468#discussion_r335180536
 
 

 ##########
 File path: 
flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java
 ##########
 @@ -213,7 +213,8 @@ public boolean isFilterPushedDown() {
 
        @Override
        public String explainSource() {
-               return "OrcFile[path=" + path + ", schema=" + orcSchema + ", 
filter=" + predicateString() + "]";
+               return "OrcFile[path=" + path + ", schema=" + orcSchema + ", 
filter=" + predicateString()
 
 Review comment:
   changed accordingly. actually the check for empty was missing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to