zhijiangW commented on a change in pull request #9905: [FLINK-14396][network]
Implement rudimentary non-blocking network output
URL: https://github.com/apache/flink/pull/9905#discussion_r335271075
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
##########
@@ -69,9 +69,7 @@
* will have an input gate attached to it. This will provide its input, which
will consist of one
* subpartition from each partition of the intermediate result.
*/
-public abstract class InputGate implements
PullingAsyncDataInput<BufferOrEvent>, AutoCloseable {
-
- protected CompletableFuture<?> isAvailable = new CompletableFuture<>();
+public abstract class InputGate extends AbstractAvailabilityProvider
implements PullingAsyncDataInput<BufferOrEvent>, AutoCloseable {
Review comment:
I ever considered making `AbstractAvailabilityProvider` as a specific helper
class, not the current abstract class, and then we use it as a protected field
in `InputGate` instead of inheriting it. But it needs also changes in
`SingleInputGate` and `UnionInputGate` for reference with
`AbstractAvailabilityProvider` in many places. And the current way does not
need to touch them.
I guess your main concern is from somewhat duplicated inheriting from
`AvailabilityProvider` in the form? Because both `AbstractAvailabilityProvider`
and `PullingAsyncDataInput` inherit from it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
