sunhaibotb commented on issue #9854: [FLINK-14230][task] Change the endInput call of the downstream operator to after the upstream operator closes URL: https://github.com/apache/flink/pull/9854#issuecomment-542507262 Thank you for the review @bremac . > It doesn't seem like there's any reason that the file reader should have to close its own output instead of letting the runtime take care of it. I think you are right. But the call to `output.close()` in `close()` was not introduced by [PR#9221](https://github.com/apache/flink/pull/9221), you can check the [L219](https://github.com/apache/flink/pull/9221/files#diff-4ad14817e962f9d344a4f6004846c28eL219) line. @bremac Maybe we can add a hotfix commit in this PR to remove that line, or we should create another PR to do this. What's your opinion? @pnowojski
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
