[
https://issues.apache.org/jira/browse/FLINK-14395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952553#comment-16952553
]
Jark Wu commented on FLINK-14395:
---------------------------------
Hi, I'm sorry, but I don't fully understand the background of this issue, even
after went through pull/9720.
>From my understanding (correct me if I'm wrong [~twalthr]), the
>{{sql-connector-xxx}} is mainly used to shade third-party dependencies and
>build an uber jar for cluster setup, and the {{flink-connector-xx}} is mainly
>used for projects to depend on directly (**no shading**).
If we want to have a clear separation between sql connectors and datastream
connectors, I'm afraid we will have a flooded number of connector modules in
the repository, and it's hard to separate them sometimes, and what's the
benefit?
> Refactor ES 6 connector to split table-specific code into
> flink-sql-connector-elasticsearch6
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-14395
> URL: https://issues.apache.org/jira/browse/FLINK-14395
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / ElasticSearch
> Reporter: vinoyang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, for ES6 connector and ES6 SQL connector, table-specific code has a
> problem with improper placement. The relevant code should be moved from es6
> connector to es6 SQL connector.
> More details and contexts, please see:
> https://github.com/apache/flink/pull/9720#issuecomment-541996415
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
