aljoscha commented on a change in pull request #9906: [FLINK-14395] Refactor ES
6 connector to split table-specific code into flink-sql-connector-elasticsearch6
URL: https://github.com/apache/flink/pull/9906#discussion_r335429828
##########
File path: flink-connectors/flink-sql-connector-elasticsearch6/pom.xml
##########
@@ -36,11 +36,65 @@ under the License.
<packaging>jar</packaging>
<dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-elasticsearch-base_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
+ <!-- Elasticsearch Java Client has been moved
to a different module in 5.x -->
+ <exclusion>
+ <groupId>org.elasticsearch</groupId>
+ <artifactId>elasticsearch</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-elasticsearch6_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
+
Review comment:
These should now be removed from the pure ES6 connector because they are not
needed anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services