zentol edited a comment on issue #9863: [FLINK-14008][release] Generate binary 
licensing during release
URL: https://github.com/apache/flink/pull/9863#issuecomment-542660464
 
 
   The core behavior works. One issue that I do run into on my system (that 
I've also had before this change) is an encoding issue with some quotes in the 
NOTICE file which are replaced with question marks after being merged. So far I 
always manually changed these back before making changes to the NOTICE-binary, 
but doing that is now a bit trickier. 
(https://issues.apache.org/jira/browse/FLINK-14413)
   
   But we can resolve this probably by just going through the modules and 
replace the few offending quotes with "normal" ones. Here's one instance where 
it happens: 
https://github.com/apache/flink/blob/88b48619e2734505a6c2ba0d53168528bc0dc143/flink-filesystems/flink-fs-hadoop-shaded/src/main/resources/META-INF/NOTICE#L1867

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to