zentol commented on a change in pull request #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#discussion_r335486818
########## File path: tools/travis/stage.sh ########## @@ -126,6 +127,10 @@ flink-connectors/flink-sql-connector-kafka," MODULES_TESTS="\ flink-tests" +MODULES_SCHEDULR_NG="\ +$MODULES_CORE,\ +$MODULES_TESTS" Review comment: I'd recommend to fully remove the annotation that you're adding and simply setting the scheduler-ng property in the scala 2.12 profile. The scheduler is scala independent anyway so that shouldn't be a problem. That way we neither have to deal with annotations, nor the resulting additional stages and maven invocations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
