WeiZhong94 commented on a change in pull request #9890:
[FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#discussion_r335784778
##########
File path: flink-python/pyflink/table/udf.py
##########
@@ -149,13 +149,12 @@ def __init__(self, func, input_types, result_type,
deterministic=None, name=None
self._deterministic = deterministic if deterministic is not None else (
func.is_deterministic() if isinstance(func, UserDefinedFunction)
else True)
- @property
- def _judf(self):
+ def _judf(self, t_env):
Review comment:
We can replace the "t_env" parameter with the boolean value
"is_blink_planner" here. The whole table_environment is unnecessary. After that
we can remove the public property "is_blink_planner" and use
"_is_blink_planner" instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
