xintongsong commented on a change in pull request #9910: [FLINK-14405][runtime]
Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory
setups.
URL: https://github.com/apache/flink/pull/9910#discussion_r335791885
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
##########
@@ -70,72 +70,88 @@
/** How many cpu cores are needed, use double so we can specify cpu
like 0.1. */
private final double cpuCores;
- /** How many java heap memory in mb are needed. */
- private final int heapMemoryInMB;
+ /** How many task heap memory are needed. */
+ private final MemorySize taskHeapMemory;
- /** How many nio direct memory in mb are needed. */
- private final int directMemoryInMB;
+ /** How many task off-heap memory are needed. */
+ private final MemorySize taskOffHeapMemory;
- /** How many native memory in mb are needed. */
- private final int nativeMemoryInMB;
+ /** How many on-heap managed memory are needed. */
+ private final MemorySize onHeapManagedMemory;
Review comment:
I would like to keep it 'onHeap'. The name _On Heap Managed Memory_ aligns
with the FLIP doc, config options, `TaskExecutorResourceSpec`, etc. I'd like to
keep them consistent for less confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
