[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953417#comment-16953417
]
Jark Wu edited comment on FLINK-14296 at 10/17/19 5:47 AM:
-----------------------------------------------------------
1.10.0: 456a17685374aaa2f17479c013fde56fc528e7fb
was (Author: jark):
1.10.0: 0a9d287a92144093b6fd648143a4805f6ae6a38d
> Improve handling of parameters nullabillity in parser module
> ------------------------------------------------------------
>
> Key: FLINK-14296
> URL: https://issues.apache.org/jira/browse/FLINK-14296
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / API
> Reporter: Dawid Wysakowicz
> Assignee: Jiayi Liao
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I want to suggest using Optional for optional parameters in classes such as
> SqlCreateTable/SqlCreateView/SqlTableColumn etc.
> Right now we must check against null at different locations e.g.:
> {code}
> SqlNodeList partitionKey = sqlCreateTable.getPartitionKeyList();
> if (partitionKey != null) {
> partitionKeys = partitionKey
> .getList()
> .stream()
> .map(p -> ((SqlIdentifier) p).getSimple())
> .collect(Collectors.toList());
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
