[
https://issues.apache.org/jira/browse/FLINK-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953548#comment-16953548
]
Zili Chen commented on FLINK-14130:
-----------------------------------
I sent another pull request rebased on current master. Please give it a look :-)
> Remove ClusterClient.run() methods
> ----------------------------------
>
> Key: FLINK-14130
> URL: https://issues.apache.org/jira/browse/FLINK-14130
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
> Reporter: Aljoscha Krettek
> Assignee: Zili Chen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{ClusterClient}} is an internal interface of the {{flink-clients}} package.
> It should only be concerned with submitting {{JobGraphs}} to a cluster, which
> is what {{submitJob()}} does.
> The {{run()}} methods are concerned with unpacking programs or job-with-jars
> and at the end use {{submitJob()}} in some way, they should reside in some
> other component. The only valid remaining run method is {{run(PackagedProgram
> prog, int parallelism)}}, this could be in {{PackagedProgramUtils}}. The
> other {{run()}} methods are actually only used in one test:
> {{ClientTest.shouldSubmitToJobClient()}}. I don't think that test is valid
> anymore, it evolved for a very long time and now doesn't test what it was
> supposed to test once.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
