[
https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956434#comment-14956434
]
ASF GitHub Bot commented on FLINK-2624:
---------------------------------------
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-147963553
There are test failures. But it seems this is not my fault.
Furthermore, I have not synchronized by the checkpointingLock when calling
addId. I think it is better if the synchronization is done inside the addId
method. Then, someone who inherits from MessageAcknowledingSourceBase does not
need to care about the synchronization.
> RabbitMQ source / sink should participate in checkpointing
> ----------------------------------------------------------
>
> Key: FLINK-2624
> URL: https://issues.apache.org/jira/browse/FLINK-2624
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Affects Versions: 0.10
> Reporter: Stephan Ewen
> Assignee: Hilmi Yildirim
>
> The RabbitMQ connector does not offer any fault tolerance guarantees right
> now, because it does not participate in the checkpointing.
> We should integrate it in a similar was as the {{FlinkKafkaConsumer}} is
> integrated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
