[
https://issues.apache.org/jira/browse/FLINK-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953802#comment-16953802
]
Jiayi Liao commented on FLINK-14364:
------------------------------------
[~twalthr] I just thought it's not worth it. We get an iterator by calling
{{objectReader.readValues(message)}} and have to check the iterator by calling
{{iterator.hasNext()}}, which is an extra calling compared with
{{objectReader.readValue(message)}}, and has a performance loss.
> Allow comments fail when not ignore parse errors in
> CsvRowDeserializationSchema
> -------------------------------------------------------------------------------
>
> Key: FLINK-14364
> URL: https://issues.apache.org/jira/browse/FLINK-14364
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
> Reporter: Jingsong Lee
> Assignee: Jiayi Liao
> Priority: Major
> Fix For: 1.10.0
>
>
> Use CsvRowDeserializationSchema, when setIgnoreParseErrors(false) and
> setAllowComments(true).
> If there are some comments in msg, will throw MismatchedInputException.
> If this a bug? and we should catch MismatchedInputException and return null?
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
