azagrebin commented on a change in pull request #9910: [FLINK-14405][runtime]
Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory
setups.
URL: https://github.com/apache/flink/pull/9910#discussion_r336044023
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/resource/NodeResourceUtil.java
##########
@@ -34,8 +34,9 @@
* Build resourceSpec from managedMem.
*/
public static ResourceSpec fromManagedMem(int managedMem) {
- ResourceSpec.Builder builder = ResourceSpec.newBuilder();
- builder.setManagedMemoryInMB(managedMem);
+ ResourceSpec.Builder builder = ResourceSpec.newBuilder(0.0, 0);
+ // TODO: before operators separate on-heap/off-heap managed
memory, we use on-heap managed memory to denote total managed memory
+ builder.setOnHeapManagedMemoryMB(managedMem);
Review comment:
Offline conclusion: defining and matching the managed memory requirement
with arbitrary type can be a follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
