twalthr commented on a change in pull request #9884: [FLINK-14266][table]
Introduce RowCsvInputFormat to new CSV module
URL: https://github.com/apache/flink/pull/9884#discussion_r336062841
##########
File path:
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/RowCsvInputFormatSplitTest.java
##########
@@ -0,0 +1,119 @@
+package org.apache.flink.formats.csv;
+
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.fs.FileInputSplit;
+import org.apache.flink.types.Row;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+
+import static org.apache.flink.formats.csv.RowCsvInputFormatTest.PATH;
+import static
org.apache.flink.formats.csv.RowCsvInputFormatTest.createTempFile;
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Test split logic for {@link RowCsvInputFormat}.
+ */
+public class RowCsvInputFormatSplitTest {
Review comment:
I'm wondering if these tests are sufficient. What about strings sourrounded
by `"` or escaped delimiters? Could you copy more tests around escaping for the
deserialization schema tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
