twalthr commented on a change in pull request #9421: [FLINK-13539][table-api]
Improve CSV table factory doesn't need to require format.fields
URL: https://github.com/apache/flink/pull/9421#discussion_r336078130
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/descriptors/OldCsv.java
##########
@@ -168,22 +170,40 @@ public OldCsv ignoreParseErrors() {
return this;
}
+ /**
+ * Derives the format schema from the table's schema. Required if no
format schema is defined.
+ *
+ * <p>This allows for defining schema information only once.
+ *
+ * <p>The names, types, and fields' order of the format are determined
by the table's
+ * schema. Time attributes are ignored if their origin is not a field.
A "from" definition
Review comment:
remove the comments about `from` and the ignoring of time attributes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
