Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-148290945
Thanks for the review in advance, @fhueske . Something i want to mention
here is that, the range partitioner implementation in this PR follow the
existed partitioner design pattern, which in my personal view, is not well
designed by the principle of object-oriented programing, the parameters of
different partitioners are passed through Flink all together, and all
partitioners logic mixed in OutputEmitter, i'm not very satisfied with the
implementation in this PR actually. I think we need refactor the partitioner as
a followup work, but this should not block this PR. Range partitioner is a
little different from other partitioners, with it enabled, we could have a
better overview about how to design the abstraction of partitioner. The
refactor should require a design doc and fully discussed in community, what do
you think about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
