docete commented on a change in pull request #9909: [FLINK-14381][table]
Partition field names should be got from CatalogTable instead of source/sink
URL: https://github.com/apache/flink/pull/9909#discussion_r336403023
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/batch/sql/PartitionableSinkITCase.scala
##########
@@ -140,9 +94,7 @@ class PartitionableSinkITCase {
"1,4,你好，陌生人，我是",
"1,4,你好，陌生人，我是中国人",
"1,4,你好，陌生人，我是中国人，你来自哪里？"),
- RESULT1.toList)
- assert(RESULT2.isEmpty)
- assert(RESULT3.isEmpty)
+ RESULT.toList)
}
@Test
Review comment:
It's weird for the test name(with dynamic) and the table sink with partition
(a, b).
Are we removed dynamic support in this legacy planner?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
