xuyang1706 commented on a change in pull request #9732: [FLINK-14153][ml] Add
to BLAS a method that performs DenseMatrix and SparseVector multiplication.
URL: https://github.com/apache/flink/pull/9732#discussion_r336440846
##########
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/linalg/BLAS.java
##########
@@ -146,4 +148,38 @@ public static void gemv(double alpha, DenseMatrix matA,
boolean transA,
final String ta = transA ? "T" : "N";
NATIVE_BLAS.dgemv(ta, m, n, alpha, matA.getData(), lda,
x.getData(), 1, beta, y.getData(), 1);
}
+
+ /**
+ * y := alpha * A * x + beta * y .
+ */
+ public static void gemv(double alpha, DenseMatrix matA, boolean transA,
+ SparseVector x, double
beta, DenseVector y) {
+ if (transA) {
Review comment:
Yes, you are right. We have created a method "gemvDimensionCheck". However,
the dimension check in "gemm" and "gemv" are totally different, so "gemm" is
left untouched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
