TisonKun opened a new pull request #9935: [FLINK-14456][client] Remove or shift down field from ClusterClient URL: https://github.com/apache/flink/pull/9935 ## What is the purpose of the change Towards a `ClusterClient` interface. ## Brief change log 1. Exclude lastJobExecutionResult from ClusterClient. Client only returns the result in submit, the tweaking logic in ContextEnvironment is hacky resolved by hold a container of execution result in ContextEnvironment. 2. Shift down ClusterClient#configuration. A follow up could be figure out what configuration is exactly used. I suspect we don't have to hold this configuration object. 3. Remove ClusterClient#shutdown. As community consensus, we already merge NewClusterClient into ClusterClient, which breaks "backward compatibility". ClusterClient is not a public interface although we possibly public it with stable interface. 4. Remove ClusterClient#getAccumulators(JobID). Only used in tests, we should always pass a classloader. There is no a good default. ## Verifying this change This change is already covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
