zhijiangW commented on issue #9905: [FLINK-14396][network] Implement 
rudimentary non-blocking network output
URL: https://github.com/apache/flink/pull/9905#issuecomment-544371931
 
 
   Thanks for the review @pnowojski .
   
   I have updated the codes for addressing above concerns. Only left one issue 
of providing non-blocking request from global `NetworkBufferPool`, and I think 
it is better to be done separately together with adjusting backpressure monitor 
later. Because when we provide `NetworkBufferPool#isAvailable` to avoid 
`availableMemorySegments.wait(2000);` in `LocalBufferPool`, it would destroy 
the exiting monitor of backpressure. And now this PR could still keep the 
previous behavior of backpressure monitor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to