docete commented on a change in pull request #9864: [FLINK-14254][table] Introduce FileSystemOutputFormat for batch URL: https://github.com/apache/flink/pull/9864#discussion_r336933865
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/sink/filesystem/FileCommitter.java ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.sink.filesystem; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.core.fs.Path; + +import java.io.Serializable; + +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * FileCommitter describes the commit of task output for file system sink. + * + * <p>See {@link FileSystemFileCommitter}. + */ +@Internal +public abstract class FileCommitter implements Serializable { + + protected final Path temporaryPath; + protected final boolean overwrite; + + public FileCommitter(Path temporaryPath, boolean overwrite) { + this.temporaryPath = temporaryPath; + this.overwrite = overwrite; + } + + /** + * Delete path, it is a recursive deletion. + */ + public abstract void deletePath(Path taskTmpPath) throws Exception; + + /** + * For committing job's output after successful batch job completion or one checkpoint finish + * for streaming job. Should move all files to final output paths. And should commit all + * checkpoint ids that less than current checkpoint id. + */ + public abstract void commit(long checkpointId) throws Exception; + + /** + * Get path generator for task. + */ + final PathGenerator pathGenerator(int taskNumber) { + return new PathGenerator(taskNumber); + } + + /** + * Path generator to generate new path to write and prepare task temporary director. Review comment: typo: director -> directory ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
