TisonKun commented on a change in pull request #9940:
[FLINK-14434][coordination] Dispatcher#createJobManagerRunner returns on
creation succeed
URL: https://github.com/apache/flink/pull/9940#discussion_r337025285
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -362,6 +362,7 @@ private boolean isPartialResourceConfigured(JobGraph
jobGraph) {
jobManagerRunnerFutures.put(jobGraph.getJobID(),
jobManagerRunnerFuture);
return jobManagerRunnerFuture
+
.thenApply(FunctionUtils.uncheckedFunction(this::startJobManagerRunner))
Review comment:
> it could happen that the Dispatcher receives a request for a job which
then being forwarded to the not yet started `JobMaster`.
We always forward request to `JobMaster` leader by
`jobManagerRunnerFuture.thenCompose(JobManagerRunner::getLeaderGatewayFuture)`
and thus I think we don't have a potential risk to execute a request on a
un-started `JobMaster`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
