zhijiangW commented on a change in pull request #9905: [FLINK-14396][network]
Implement rudimentary non-blocking network output
URL: https://github.com/apache/flink/pull/9905#discussion_r337325076
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/ConsumableNotifyingResultPartitionWriterDecorator.java
##########
@@ -119,6 +121,11 @@ public void fail(Throwable throwable) {
partitionWriter.fail(throwable);
}
+ @Override
+ public CompletableFuture<?> isAvailable() {
+ return AvailabilityProvider.AVAILABLE;
Review comment:
Thanks for finding this critical issue. It was my careless to take it simple
as other tests way.
Actually the `ConsumableNotifyingResultPartitionWriterDecorator` is used by
`RecordWriter` in practice, so we should create this decorator in new added
test `RecordWriterTest#testIsAvailableOrNot` to cover this issue. And I already
fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
