tillrohrmann commented on issue #9928: [FLINK-12122] Add support for spreading slots out across all TaskExecutors URL: https://github.com/apache/flink/pull/9928#issuecomment-544929438 Thanks a lot for your review @xintongsong. I've addressed most of you comments. Concerning the configuration of this feature my reasoning was the following: I'm not entirely sure whether spread out for standalone and bin packing for Yarn is always the best option. Consider for example a workload which rather benefits from co-locating operators on the same `TaskExecutor` because of the reduced network I/O. These jobs would then degrade when being executed on a standalone cluster with slot spreading. Moreover, I would like to avoid to introduce too much magic. In the past we have seen that implicit behaviour can be hard to understand if not properly documented. Usually, I think that making things explicit and consistent across different setups is easier for users to understand. Since I don't see a superior option here, I believe that this option needs to be configurable. Concerning the config option itself: I opted for a boolean option because currently it is the simplest option for our use case and I cannot foresee future option values. In the past we have seen that optimizing/designing for future additions usually does not pay off because sometimes these additions won't come. The important bit here would be that we don't block the addition of more strategies in the future. I believe that this is the case. A potential strategy would be to deprecate `EVENLY_SPREAD_OUT_SLOTS_STRATEGY` and to use this value if the newly introduced configuration value has not been specified.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
