tillrohrmann commented on a change in pull request #9936:
[FLINK-14450][runtime] Change SchedulingTopology to extend base topology
URL: https://github.com/apache/flink/pull/9936#discussion_r337636460
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -259,7 +259,7 @@
private PartitionReleaseStrategy partitionReleaseStrategy;
- private SchedulingTopology schedulingTopology;
+ private SchedulingTopology<?, ?> schedulingTopology;
Review comment:
It would mainly be a safeguard against using this class in a wrong way or
against faulty refactorings. What you are mentioning goes a couple of steps
farther. At the moment I think we don't use the lazy attaching mechanism and,
hence, we could remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
