walterddr commented on a change in pull request #9732: [FLINK-14153][ml] Add to
BLAS a method that performs DenseMatrix and SparseVector multiplication.
URL: https://github.com/apache/flink/pull/9732#discussion_r337844005
##########
File path:
flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/linalg/BLAS.java
##########
@@ -19,26 +19,53 @@
package org.apache.flink.ml.common.linalg;
+import org.apache.flink.util.Preconditions;
+
/**
* A utility class that provides BLAS routines over matrices and vectors.
*/
public class BLAS {
+
+ // For level-1 routines, we use Java implementation.
private static final com.github.fommil.netlib.BLAS NATIVE_BLAS =
com.github.fommil.netlib.BLAS.getInstance();
+
+ // For level-2 and level-3 routines, we use the native BLAS.
private static final com.github.fommil.netlib.BLAS F2J_BLAS =
com.github.fommil.netlib.F2jBLAS.getInstance();
Review comment:
comment and code doesn't align.
* the field name is `NATIVE_BLAS` for the level-1,
* the field name is `F2J_BLAS` for level-2,3.
any naming conversion problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
