zentol commented on a change in pull request #9859: [FLINK-11405][rest]rest api
can more exceptions by query parameter
URL: https://github.com/apache/flink/pull/9859#discussion_r337904959
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandler.java
##########
@@ -49,15 +50,15 @@
/**
* Handler serving the job exceptions.
*/
-public class JobExceptionsHandler extends
AbstractExecutionGraphHandler<JobExceptionsInfo, JobMessageParameters>
implements JsonArchivist {
+public class JobExceptionsHandler extends
AbstractExecutionGraphHandler<JobExceptionsInfo,
JobExceptionsMessageParameters> implements JsonArchivist {
- static final int MAX_NUMBER_EXCEPTION_TO_REPORT = 20;
+ private static int maxNumberExceptionToReport = 20;
Review comment:
it's a bad idea to use a mutable field for passing arguments around. Revert
this change and add another argument to `createJobExceptionsInfo()` instead and
propagate it to `handleRequest()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
