TisonKun commented on issue #9972: [FLINK-14496][client] Exclude detach flag 
from ClusterClient
URL: https://github.com/apache/flink/pull/9972#issuecomment-545375104
 
 
   I'm glad to revisit the calls chain to reduce `toJobExecution(classLoader)` 
where we don't require it.
   
   For submission, it is not different we call `client.submitJob(...).get()` 
and `ClientUtils.submitJob(client, jobGraph).get()`.
   
   For wait for job result, compare 
`client.submitJob(...).thenCompose(...).get()` with 
`ClientUtils.submitJobAndWaitForResult(client, jobGraph).get()`
   
   For deserialization, compare passing a ClassLoader to 
`ClientUtils.submitJobAndWaitForResult` or 
`ClientUtils.submitJobAndWaitForDeserializedResult` and 
`...toJobExecutionResult(ClassLoader)` 
   
   These actions are simple enough to inline IMO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to