twalthr commented on a change in pull request #9976: [FLINK-14493][core] Introduce data types to ConfigOptions. URL: https://github.com/apache/flink/pull/9976#discussion_r338064895
########## File path: flink-core/src/main/java/org/apache/flink/configuration/StructuredOptionsSplitter.java ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.configuration; + +import org.apache.flink.annotation.Internal; + +import javax.annotation.Nullable; + +import java.util.ArrayList; +import java.util.List; +import java.util.Objects; + +/** + * Helper class for splitting a string on a given delimiter with quoting logic. + */ +@Internal +class StructuredOptionsSplitter { + + private enum State { + CONSUMING, + SINGLE_QUOTED_CONSUMING, + DOUBLE_QUOTED_CONSUMING, + UNKNOWN + } + + private State state = State.UNKNOWN; + private final List<String> splits = new ArrayList<>(); + private StringBuilder builder = new StringBuilder(); + + /** + * Splits the given string on the given delimiter. It supports quoting parts of the string with + * either single (') or double quotes ("). Quotes can be escaped by doubling the quotes. + * + * <p>Examples: + * <ul> + * <li>'A;B';C => [A;B], [C]</li> + * <li>"AB'D";B;C => [AB'D], [B], [C]</li> + * <li>"AB'""D;B";C => [AB'\"D;B], [C]</li> Review comment: Shall we allow whitespace like `'a' ; 'b'` or `'a'; 'b'`? Having a space after a comma or semicolon is common and could cause problems easy. I thing we should trim valued that are not quoted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
