xuefuz commented on a change in pull request #9937: [FLINK-14416][table] Add
Module interface and ModuleManager
URL: https://github.com/apache/flink/pull/9937#discussion_r338146922
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
##########
@@ -103,6 +106,23 @@ static TableEnvironment create(EnvironmentSettings
settings) {
*/
Optional<Catalog> getCatalog(String catalogName);
+ /**
+ * Load a {@link Module} under a unique name.
+ *
+ * @param moduleName name of the {@link Module}
+ * @param module the module instance
+ * @throws ModuleAlreadyExistException thrown when there is already a
module with the same name
Review comment:
Please make the comments for loadModule() and unloadModule() in a similar
style as existing methods. For instance, Load => Loads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
