godfreyhe commented on a change in pull request #9876: [FLINK-14134][table]
Introduce LimitableTableSource for optimizing limit
URL: https://github.com/apache/flink/pull/9876#discussion_r338362335
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/LimitTest.scala
##########
@@ -90,4 +96,28 @@ class LimitTest extends TableTestBase {
util.verifyPlan("SELECT a, c FROM MyTable OFFSET 10 ROWS")
}
+ @Test
+ def testFetchWithLimitSource(): Unit = {
Review comment:
please add a test with `order by`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
