wuchong commented on a change in pull request #9916:
[FLINK-14408][Table-Planner]UDF's open method is invoked to initialize when sql
is optimized in oldPlanner
URL: https://github.com/apache/flink/pull/9916#discussion_r338363743
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/codegen/ExpressionReducer.scala
##########
@@ -94,8 +99,15 @@ class ExpressionReducer(config: TableConfig)
val literalTypes = literals.map(e =>
FlinkTypeFactory.toTypeInfo(e.getType))
val resultType = new RowTypeInfo(literalTypes: _*)
+ val parameters = if (config.getConfiguration != null) {
+ config.getConfiguration
Review comment:
Currently, we use `ExecutionConfig#getJobParameter` as the UDF's
configuration in runtime. However, I think we should use
`TableConfig#getConfiguration`. I opened another issue FLINK-14514 to discuss
this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
