wuchong commented on a change in pull request #9952: [FLINK-14321][sql-parser]
Support to parse watermark statement in SQL DDL
URL: https://github.com/apache/flink/pull/9952#discussion_r338364936
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -310,9 +322,67 @@ private void printIndent(SqlWriter writer) {
public List<SqlNode> columnList = new ArrayList<>();
public SqlNodeList primaryKeyList = SqlNodeList.EMPTY;
public List<SqlNodeList> uniqueKeysList = new ArrayList<>();
+ @Nullable public SqlWatermark watermark;
}
public String[] fullTableName() {
return tableName.names.toArray(new String[0]);
}
+
+ //
-------------------------------------------------------------------------------------
+
+ private static final class ColumnValidator {
+
+ private final Set<String> allColumnNames = new HashSet<>();
+
Review comment:
This is not only used for field name checking, but also used for rowtime
field reference check. During column expression conversion, there is still no
validation for rowtime field. We need to validate the rowtime field exactly
exists, even if it is a nested field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
